Skip to content

gh-122838: Document missing opcodes #123073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2024
Merged

gh-122838: Document missing opcodes #123073

merged 2 commits into from
Nov 6, 2024

Conversation

@kamilturek
Copy link
Contributor

@kamilturek kamilturek commented Aug 16, 2024 •
edited by github-actions bot
Loading

Relates to #122838.

This PR adds documentation for LOAD_FAST_LOAD_FAST, STORE_FAST_STORE_FAST, STORE_FAST_LOAD_FAST.

LOAD_FROM_DICT_OR_DECREF, LOAD_FROM_DICT_OR_GLOBALS are already documented.

I'm not quite sure what ENTER_EXECUTOR does.

📚 Documentation preview 📚: https://cpython-previews--123073.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request Aug 16, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Aug 16, 2024
@picnixz
Copy link
Member

picnixz commented Aug 16, 2024

cc @markshannon @iritkatriel

@kamilturek kamilturek marked this pull request as ready for review August 16, 2024 19:53
MatthieuDartiailh
MatthieuDartiailh reviewed Aug 17, 2024
View reviewed changes
@MatthieuDartiailh
Copy link
Contributor

Anything I can do to help to get this merged ?

@iritkatriel iritkatriel added the needs backport to 3.13 bugs and security fixes label Nov 6, 2024
@iritkatriel iritkatriel enabled auto-merge (squash) November 6, 2024 11:45
@iritkatriel iritkatriel merged commit 9cba47d into python:main Nov 6, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @kamilturek for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2024
@kamilturek @miss-islington
pythongh-122838: Document missing opcodes (pythonGH-123073)
ba1b233 
(cherry picked from commit 9cba47d)

Co-authored-by: Kamil Turek <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 6, 2024

GH-126492 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 6, 2024
@kamilturek kamilturek deleted the gh-122838 branch November 6, 2024 12:17
Yhg1s pushed a commit that referenced this pull request Dec 2, 2024
@miss-islington @kamilturek
[3.13] gh-122838: Document missing opcodes (GH-123073) (#126492)
d9bbb52 
gh-122838: Document missing opcodes (GH-123073)
(cherry picked from commit 9cba47d)

Co-authored-by: Kamil Turek <[email protected]>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@kamilturek @picnixz
pythongh-122838: Document missing opcodes (python#123073)
9d31e5a
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@kamilturek @ebonnal
pythongh-122838: Document missing opcodes (python#123073)
ae3375f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

+1 more reviewer

@MatthieuDartiailh MatthieuDartiailh MatthieuDartiailh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kamilturek @picnixz @MatthieuDartiailh @iritkatriel